PDI-1454: CLI v2 Command: Custom Request #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erikostien-pingidentity
commented
Sep 19, 2024
erikostien-pingidentity
commented
- Add Command Usage examples and Configuration format examples to cobra usage messages where applicable.
- Unite all Pingone and Pingfederate configuration options under 'service' parent, now used by both 'platform export' and 'request' commands.
- Add 'authentication' parent in service configuration to allow the user to directly specify which authentication method to use. This removes the flag exclusivity requirement on 'platform export' command, as well as removes authentication "heirarchy" in pingfederate go-client authentication logic.
- Refactor MultiService custom map type to ExportServices []string type.
- Add new command 'request' to send custom request to PingIdentity services. Currently, only PingOne is supported.
- Add multiple additional custom types to support Ints, authentication types, http methods, and request services.
- In the configuration file, support Yaml array lists for scopes, CA cert files, and Export services.
- Use PingOne region codes instead of deprecated PingOne Regions.
- Various testing fixes and additions.
- Add Command Usage examples and Configuration format examples to cobra usage messages where applicable. - Unite all Pingone and Pingfederate configuration options under 'service' parent, now used by both 'platform export' and 'request' commands. - Add 'authentication' parent in service configuration to allow the user to directly specify which authentication method to use. This removes the flag exclusivity requirement on 'platform export' command, as well as removes authentication "heirarchy" in pingfederate go-client authentication logic. - Refactor MultiService custom map type to ExportServices []string type. - Add new command 'request' to send custom request to PingIdentity services. Currently, only PingOne is supported. - Add multiple additional custom types to support Ints, authentication types, http methods, and request services. - In the configuration file, support Yaml array lists for scopes, CA cert files, and Export services. - Use PingOne region codes instead of deprecated PingOne Regions. - Various testing fixes and additions.
henryrecker-pingidentity
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.