Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static sitemap, generate 'dynamic' sitemap #66

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

kevinmitch14
Copy link
Contributor

@kevinmitch14 kevinmitch14 commented Apr 15, 2023

Current sitemap.xml has static <lastmod>2023-04-06</lastmod>. This will have to be changed manually or will always stay as the same outdated value.

Replaced it with a generated Sitemap (see NextJS docs).

Old output:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <url>
    <loc>https://marker.ping.gg</loc>
    <lastmod>2023-04-06</lastmod>
  </url>
</urlset>

New output:

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <url>
    <loc>https://marker.ping.gg</loc>
    <lastmod>2023-04-06T15:02:24.021Z</lastmod>
  </url>
</urlset>

However, <lastmod/> will always be up to date with new approach, because it is using new Date() on build.

@vercel
Copy link

vercel bot commented Apr 15, 2023

@kevinmitch14 is attempting to deploy a commit to the Ping Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
markerthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 11:21pm

@t3dotgg t3dotgg merged commit 69379ba into pingdotgg:main Apr 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants