Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a compaction filter long term case #378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Mar 3, 2021

Signed-off-by: qupeng [email protected]

What problem does this PR solve?

Add a long term case for GC in Compaction Filter.

What is changed and how does it work?

The case has such features:

  • Has both long records and short records, which covers different code path for GC in compaction filter.
  • 3 SQLs are contianed in its workload: update/delete/insert.
  • 4 actions on TiKV side: MVCC_PUT(record), MVCC_PUT(index), MVCC_DELETE(record), MVCC_DELETE(index).
  • A simple transaction consistency checker during running, like bank2, but no transaction log tracing.

TODO list

  • Support to automatic run it on tipocket.

Check List

Tests

  • No code

Code changes

  • Has Go code change

Does this PR introduce a user-facing change?:

NONE

@mahjonp
Copy link
Contributor

mahjonp commented Mar 5, 2021

  • Support to automatic run it on tipocket.

This test case couldn't run on tipocket now since the dependencies are lack in the docker image, I plan to let each test case owns a Dockerfile so that dependencies and manifests(Lua, Sysbench, etc) can be contained on the split images.

Until then, this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants