feat: support log volume binding #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
…rom it. Signed-off-by: mahjonp <[email protected]>
cosven
reviewed
Jan 28, 2021
pkg/test-infra/tidb/template.go
Outdated
| @@ -74,7 +74,8 @@ then | |||
| fi | |||
| echo "start tidb-server ..." | |||
| echo "/tidb-server ${ARGS}" | |||
| exec /tidb-server ${ARGS} | |||
| /tidb-server ${ARGS} 2>&1 | tee -a /var/log/tidblog/tidb.log | |||
| # ^^: append mode | |||
There was a problem hiding this comment.
How about set log-file to /var/log/tidblog/tidb.log in config file?
Pros:
- It will auto rotate log
- configurable
- daily run case are controlled by admin, we can ensure that these cases use correct config
There was a problem hiding this comment.
That's troubling to me, I need such a tool to help me:
- run the tikv-server in the background
- log tail tikv.log to stdout
- exit with the exit-code when tikv-server exits
There was a problem hiding this comment.
resolve in 448bc24.
The solution here is that I let tail -F running in the background but let it output to stdout, and run tikv-server...
Signed-off-by: mahjonp <[email protected]>
|
Resolve the log store and avoid loss issue that has recorded in #321 |
|
LGTM |
cosven
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mahjonp [email protected]
What is changed and how does it work?
Since the TiDB-Operator has supported mounting PV into containers, this PR updates recommend TiDB ops configuration with a log PV binding with TiDB container and save all main component log into PVs.
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: