*: Add index_id to ANNQueryInfo to support multiple indexes on the same column #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
force-pushed
the
support-multi-vec-index
branch
from
b656bed to
61012c7
Compare
JaySon-Huang
commented
Aug 22, 2024
| @@ -127,11 +127,14 @@ message ANNQueryInfo { | |||
| optional VectorDistanceMetric distance_metric = 2 [(gogoproto.nullable) = false]; | |||
| optional uint32 top_k = 3 [(gogoproto.nullable) = false]; | |||
| optional string column_name = 4 [(gogoproto.nullable) = false]; // For debug purpose only. Currently only used in explain. | |||
| optional int64 column_id = 5 [(gogoproto.nullable) = false]; | |||
| optional int64 column_id = 5 [(gogoproto.nullable) = true]; | |||
There was a problem hiding this comment.
Is it ok to turn this into a nullable field? @breezewish @zimulala
There was a problem hiding this comment.
I think TiFlash and TiDB using the correct tipb version should work just fine. I am not sure. @breezewish please help to confirm it
There was a problem hiding this comment.
@breezewish PTAL
breezewish
approved these changes
Aug 26, 2024
zimulala
approved these changes
Aug 26, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref pingcap/tidb#54245
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn: