-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncer(dm): option for explicit auto-id-cache handling in create table DDLs #12040
base: master
Are you sure you want to change the base?
syncer(dm): option for explicit auto-id-cache handling in create table DDLs #12040
Conversation
Hi @michaelmdeng. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Michael Deng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
622a2ad
to
4ee38f7
Compare
4aa676d
to
c43a3d9
Compare
/ok-to-test |
@michaelmdeng: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #12039
What is changed and how it works?
Adds a new
auto-id-cache-size
Syncer config. When set, DM incremental replication of new tables will update the create table statement w/ the corresponding auto-id-cache size. When unset (0 or default), the statement will be left as is.I believe this change should not affect other DM components, including import for "full" or "all" mode, but would appreciate guidance here as well.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
Yes, needs documentation on the new config setting and its purpose/usage.
Release note