Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(redo)ticdc: fix the event orderliness in redo log (#11117) #11155

Merged
merged 8 commits into from
May 22, 2024
Merged

(redo)ticdc: fix the event orderliness in redo log (#11117) #11155

merged 8 commits into from
May 22, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11117

What problem does this PR solve?

Issue Number: close #11096

What is changed and how it works?

  1. Fix the less function of logHeap to make dml event of redo log in the same txn sorted as delete/update/insert.
  2. use startTs instead of commitTs in redo apply to distinguish different txns.

Check List

Tests

  • Unit test

  • Manual test (add detailed scripts or steps below)

    create mysql sink changefeed with redo log on
    run gotpc workload
    After 30m, pause changefeed and run redo apply

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 21, 2024
Merged
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 21, 2024
@hongyunyan
Copy link
Collaborator

/retest

1 similar comment
@hongyunyan
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 22, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 22, 2024
@hongyunyan
Copy link
Collaborator

/retest

3 similar comments
@hongyunyan
Copy link
Collaborator

/retest

@hongyunyan
Copy link
Collaborator

/retest

@hongyunyan
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7806104 into pingcap:release-7.5 May 22, 2024
13 checks passed
@fubinzh fubinzh mentioned this pull request Jun 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees

@hongyunyan hongyunyan

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ti-chi-bot @hongyunyan @CharlesCheung96