Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} (#11122) #11154

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11122

What problem does this PR solve?

Issue Number: close #11121

What is changed and how it works?

When cherry-pick this PR to release branches, remember to pick the fix PR of pingcap/tidb#53357 to tidb as well

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 21, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 21, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-11122-to-release-7.5 branch from 5e66512 to 1b0b889 Compare May 21, 2024 08:55
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 1b0b889 link true /test verify
pull-cdc-integration-storage-test 1b0b889 link true /test cdc-integration-storage-test
pull-cdc-integration-kafka-test 1b0b889 link true /test cdc-integration-kafka-test
pull-cdc-integration-mysql-test 1b0b889 link true /test cdc-integration-mysql-test
pull-engine-integration-test 1b0b889 link true /test engine-integration-test
pull-dm-integration-test 1b0b889 link true /test dm-integration-test
pull-cdc-integration-pulsar-test 1b0b889 link true /test cdc-integration-pulsar-test
pull-dm-compatibility-test 1b0b889 link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 22, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 22, 2024
@3AceShowHand
Copy link
Contributor

closed by #11168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants