Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation error on arm64 #9839

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix compilation error on arm64 #9839

merged 2 commits into from
Feb 5, 2025
+128 −77

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Jan 28, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9838

Problem Summary:
move methods implementation from ColumnDecimal.h to ColumnDecimal.cpp

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 28, 2025
@guo-shaoge
Copy link
Contributor Author

/retest

@guo-shaoge
fmt
120219e 
Signed-off-by: guo-shaoge <[email protected]>
xzhangxian1008
xzhangxian1008 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 5, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 03:21:57.19129693 +0000 UTC m=+241988.723708913: ☑️ agreed by xzhangxian1008.
  • 2025-02-05 03:37:07.478610468 +0000 UTC m=+242899.011022465: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 4abb401 into pingcap:master Feb 5, 2025
5 checks passed
@guo-shaoge guo-shaoge deleted the fix_arm_complation branch February 5, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compilation error on arm64: undefined symbol deserializeAndInsertFromPosImpl
3 participants
@guo-shaoge @JaySon-Huang @xzhangxian1008