Remove some code

pkg/diff/spliter_test.go

@@ -455,7 +455,6 @@ func createFakeResultForBucketSplit(mock sqlmock.Sqlmock, aRandomValues, bRandom
 	for i := 0; i < 5; i++ {
 		statsRows.AddRow("test", "test", "PRIMARY", 1, (i+1)*64, (i+1)*64, 1, fmt.Sprintf("(%d, %d)", i*64, i*12), fmt.Sprintf("(%d, %d)", (i+1)*64-1, (i+1)*12-1))
 	}
-
 	mock.ExpectQuery("SHOW STATS_BUCKETS").WillReturnRows(statsRows)
 
 	for i := 0; i < len(aRandomValues); i++ {

sync_diff_inspector/splitter/random.go

@@ -203,7 +203,6 @@ func (s *RandomIterator) Close() {
 }
 
 // GetSplitFields returns fields to split chunks, order by pk, uk, index, columns.
-// Return the columns, corresponding index name and error
 func GetSplitFields(table *model.TableInfo, splitFields []string) ([]*model.ColumnInfo, error) {
 	colsMap := make(map[string]*model.ColumnInfo)
 
@@ -225,19 +224,20 @@ func GetSplitFields(table *model.TableInfo, splitFields []string) ([]*model.Colu
 		colsMap[col.Name.O] = col
 	}
 
-	// First try to get column from index
 	indices := dbutil.FindAllIndex(table)
-NEXTINDEX:
-	for _, idx := range indices {
-		cols := make([]*model.ColumnInfo, 0, len(table.Columns))
-		for _, icol := range idx.Columns {
-			col := colsMap[icol.Name.O]
-			if col.Hidden {
-				continue NEXTINDEX
+	if len(indices) != 0 {
+	NEXTINDEX:
+		for _, idx := range indices {
+			cols := make([]*model.ColumnInfo, 0, len(table.Columns))
+			for _, icol := range idx.Columns {
+				col := colsMap[icol.Name.O]
+				if col.Hidden {
+					continue NEXTINDEX
+				}
+				cols = append(cols, col)
 			}
-			cols = append(cols, col)
+			return cols, nil
 		}
-		return cols, nil
 	}
 
 	for _, col := range table.Columns {

sync_diff_inspector/utils/utils_test.go

@@ -269,8 +269,7 @@ func TestGetCountAndMd5Checksum(t *testing.T) {
 	tableInfo, err := dbutil.GetTableInfoBySQL(createTableSQL, parser.New())
 	require.NoError(t, err)
 
-	mock.ExpectQuery("SELECT COUNT.*FROM `test_schema`\\.`test_table`").WithArgs("123", "234").WillReturnRows(sqlmock.NewRows([]string{"CNT", "CHECKSUM"}).AddRow(123, 456))
-
+	mock.ExpectQuery("SELECT COUNT.*FROM `test_schema`\\.`test_table` WHERE \\[23 45\\].*").WithArgs("123", "234").WillReturnRows(sqlmock.NewRows([]string{"CNT", "CHECKSUM"}).AddRow(123, 456))
 	count, checksum, err := GetCountAndMd5Checksum(ctx, conn, "test_schema", "test_table", tableInfo, "[23 45]", "", []interface{}{"123", "234"})
 	require.NoError(t, err)
 	require.Equal(t, count, int64(123))