cloud: add a note before changing vCPU #20952
Conversation
ti-chi-bot
bot
added
contribution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @jinwhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the scale-tidb-cluster.md documentation file to include a note about decreasing vCPU after increasing TiKV/TiFlash node storage. Specifically, it clarifies that after increasing TiKV/TiFlash node storage, decreasing the vCPU of TiKV/TiFlash is not possible without recreating the cluster, due to the binding between max node storage and vCPU.
Highlights
- Documentation Update: The documentation is updated to reflect the limitation of decreasing vCPU after increasing TiKV/TiFlash node storage.
- TiKV/TiFlash Scaling: Clarification on the dependency between node storage and vCPU when scaling TiKV/TiFlash components.
Changelog
- tidb-cloud/scale-tidb-cluster.md
- Added a note explaining that decreasing vCPU of TiKV/TiFlash is not possible after increasing node storage without recreating the cluster.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Hi @jinwhu. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request updates the scale-tidb-cluster.md file to include a note about decreasing vCPU after increasing TiKV/TiFlash storage. The change is straightforward, and the added information is useful for users. However, there are some minor grammatical and stylistic issues that can be improved.
Summary of Findings
- Clarity and Grammar: The sentence about vCPU and storage dependency could be clearer and grammatically improved.
Merge Readiness
The pull request is almost ready for merging. Addressing the clarity and grammatical issues in the added note would improve the overall quality of the documentation. I am unable to approve the pull request, and users should have others review and approve this code before merging.
tidb-cloud/scale-tidb-cluster.md
Outdated
| > - Hosted on AWS and created after 2022/12/31. | ||
| > - Hosted on Google Cloud and created after 2023/04/26. | ||
| > - AWS has a cooldown period of vCPU and RAM changes. If your TiDB cluster is hosted on AWS, after changing the storage or vCPU and RAM of TiKV or TiFlash, you must wait at least six hours before you can change it again. | ||
| > - Before decrease VCPU, you need to ensure TiKV/TiFlash's current node storage does not exceed target vCPU's corresponding maximum node storage [TiDB Cloud TiKV/TiFlash Storage Size](https://docs.pingcap.com/tidbcloud/size-your-cluster/#tiflash-node-storage). If any component's current storage exceeds the maximum, decreasing VCPU is prohibited. |
|
lgtm |
Oreoxmt
added
translation/no-need
ti-chi-bot
bot
removed
the
missing-translation-status
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
|
/bot-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
✅ AI review completed, 1 comments generated. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Oreoxmt
changed the title
[LGTM Timeline notifier]Timeline:
|
|
@qqqdan: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oreoxmt
added
the
cherry-pick-release-cloud/no-need
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?