The MiniPaint integration #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
6e352c0 to
dfad5ba
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
b3f1a6a to
b935b23
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
9d57b43 to
a2ad250
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
68e3c8a to
4df58e2
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
85fb81d to
8d1678c
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
fad8b9f to
a3484c9
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
205ee99 to
ceeeb75
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
363eb16 to
0844b78
Compare
vin0401
requested changes
Jan 9, 2025
There was a problem hiding this comment.
I saw that you introduced a new folder called services.
I'm not sure what the purpose/meaning of this folder is.
Could elaborate a bit on that?
Right now, we already have a lib folder maybe that one would also be suitable not sure.
For me services are more like useful classes/objects that are provided via our dependency injection container. So I'm not sure if the name is really suitable in that case.
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
6198601 to
799f10b
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
42fbfe4 to
ef45dae
Compare
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
32f3e52 to
fcdd074
Compare
vin0401
approved these changes
Jan 13, 2025
|
@ValeriaMaltseva Only found one small topic (see my comment). Other then that I tested it a bit and everything seems to be fine. We can merge it after checking my comment. 👍 |
ValeriaMaltseva
force-pushed
the
740-minipaint
branch
from
26086f6 to
6776111
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #740