Skip to content

Eliminate unneeded work when missing signing keys #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smcmurray wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Eliminate unneeded work when missing signing keys #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f6159
Allow maxAge of 0. Eliminate unneeded work when missing signing keys
smcmurray May 20, 2018
acd7548
Removed maxAge PR
smcmurray May 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ Cookies.prototype.get = function(name, opts) {
value = match[1]
if (!opts || !signed) return value

if (!this.keys) throw new Error('.keys required for signed cookies');

remote = this.get(sigName)
if (!remote) return

data = name + "=" + value
if (!this.keys) throw new Error('.keys required for signed cookies');
index = this.keys.index(data, remote)

if (index < 0) {
Expand Down Expand Up @@ -162,7 +163,7 @@ Cookie.prototype.toString = function() {
Cookie.prototype.toHeader = function() {
var header = this.toString()

if (this.maxAge) this.expires = new Date(Date.now() + this.maxAge);
if (this.maxAge || 0 === this.maxAge) this.expires = new Date(Date.now() + this.maxAge);

if (this.path ) header += "; path=" + this.path
if (this.expires ) header += "; expires=" + this.expires.toUTCString()
Expand Down