Linter and link fixes, allow handling of "abort error" #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, ty for this initiative, I really appreciate. I planned to do a lot of changes soon like you did, because several enhancement about go, tools and linters exists since I start to impl this library. And many idea to enhance this lib to do in my head. I'm ok to merge your contributions asap to restart the machine on this project. Please let me know when it will be not a draft. Have a good day :) |
|
I re-run |
pilebones
force-pushed
the
master
branch
3 times, most recently
from
5c1ec37 to
c3fe89d
Compare
|
Yes, I will be happy to! |
hut8
force-pushed
the
liam/linter-and-link-fixes
branch
from
0b44c10 to
01072ba
Compare
|
Rebased: let me know what you think 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a group of a couple of fixes:
return errors.New("abort signal receive")was present in the middle of a function during the crawling of/sys/devices. That makes it so that we can't distinguish between that particular error and any other error (at least, not easily). That error is special because it's one that's actually triggered by the user just to stop the crawling process, so the user is very likely to treat it as not an error. This makes that possible.ioutilhas been deprecated for a long time now, so I replaced that withio.*oros.*.