Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make transliteration configurable #279

Merged
merged 1 commit into from
Oct 17, 2023
Merged

make transliteration configurable #279

merged 1 commit into from
Oct 17, 2023

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Oct 10, 2023 •
edited
Loading

fixes #13

screenshot20231010_125208306

@jmlich
Copy link
Contributor Author

jmlich commented Oct 10, 2023

It would be great to add reasonable defaults. For example enabled for PineTime.

@jmlich
Copy link
Contributor Author

jmlich commented Oct 10, 2023

I have reused function sendAlert in deviceInterface. I am not sure about intention while using sometimes m_device->sendAlert(...) and in other cases just sendAlert(...). It can be related to check of the same/repeated notification.

@piggz piggz merged commit 98bd0b4 into piggz:master Oct 17, 2023
@jmlich jmlich deleted the transliterate-as-settings branch October 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Umlauts are displayed as [?] (UTF)
2 participants
@jmlich @piggz