Add support for the upload procedure of external resource for the PineTime (running InfiniTime). #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piggz
reviewed
Sep 3, 2022
| @@ -34,6 +39,6 @@ void InfinitimeFirmwareInfo::determineFirmwareVersion() | |||
| m_version = "FW ()"; | |||
| break; | |||
| default: | |||
| m_version = "unknown"; | |||
| m_version = "Ressource ()"; | |||
piggz
reviewed
Sep 3, 2022
…eTime (running InfiniTime).
…ng files before uploading the new content.
…ces must be uploaded. Handle error code from the BLEFS service.
JF002
force-pushed
the
pinetime-add-support-for-external-resource
branch
from
4a04e6e to
a270c98
Compare
|
I've just rebased this branch on master, fixed conflicts and add a few steps in the upload procedure (create folder and subfolder, correctly remove older entries, remove obsolete files). The corresponding feature has already been merged in InfiniTime, so this branch is ready for review :) |
piggz
reviewed
Sep 16, 2022
| @@ -15,7 +15,7 @@ PageListPL { | |||
| var pairpage = pageStack.push(Qt.resolvedUrl("./PairPage.qml")); | |||
| pairpage.deviceType = deviceType;}) | |||
| } else { | |||
| var pairpage = pageStack.push(Qt.resolvedUrl("./PairPage.qml")); | |||
| var pairpage = pageStack.push(Qt.resolvedUrl("/home/jf/git/harbour-amazfish/ui/qml/pages/PairPage.qml")); | |||
There was a problem hiding this comment.
Yes, sorry about that... I changed the path to debug an issue with the pairing page, and I shouldn't have committed that! I reverted that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At InfiniTime, we are working on adding support for external resources : applications and watchfaces will be able to load images and fonts stored in the external SPI flash memory of the PineTime.
This is working quite well. See here and here.
Those resources are packaged into a ZIP file together with a "manifest file" that describes the mapping of the files into the watch. See here.
Now, we need companion apps to implement the upload procedure so users can easily update the resources from their device.
This PR contains the implementation of the Adafruit BLE File Transfer Protocol (the BLE FS API implemented in InfiniTime) and of the upload procedure specified for InfiniTime.
Note that the feature is not merged yet in InfiniTime, we are still doing some tests and waiting for other companion apps to add this feature.
Basically, this PR add
AdafruitBleFsServicewhich is the entry point for the Adafruit BLE File Transfer Protocol,AdafruitBleFsServicewhich contains operations on the API (list, erase, write file) andAdafruitBleFsWorkerwhich implements the upload procedure.