-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deprecated rules in sass 2.0 & updated dependencies #685
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$version in src/_variables.scss misses a 0
fixed |
Can this be merged? |
Yes (but I do not have write access) |
@jviotti do you have write access? |
I do not, sorry @salamwaddah |
Dear @codebling please, would you mind accepting 🙏 |
@blokhin why are you tagging me?? I don't have any access to this repo |
I've approved, in case that helps. |
Ah, sorry, I've thought you might have the necessary rights. Unfortunately, the repo author Yan Zhu @picturepan2 does not respond for almost a year. |
That's unfortunate. Perhaps time for a fork? |
There is a SpectreCSS organisation, made by @picturepan2: Ping: @codebling @jviotti @devmount I really wish to continue using Spectre.css, and I am willing to contribute to it’s development. |
@peterhil are you tagging me because you want me to move the repo? I have no access to this repo. Nobody except picturepan2 has access to this repo, as far as I can tell, and they have not been responsive to @ mentions in this repo for quite some time. The good news is, it's open source. I suggest someone fork (possibly into the org you mentioned) and add others as admins to the repo. |
To everyone who needs this, you can just do:
No other changes needed. @Valexr - in lieu of someone creating a new repo and merging all the pending PRs, will you keep your repo up? |
I don't think so... @davestewart , there's no time to do it. I did it exclusively for a project that I don't support anymore. |
Ok, thanks for the info. I'll fork! |
I am using spectre.css in my projects a lot and really love its simplicity. So sad there is no solution to continue it within the current repo/setup/org. In case there is any interest I would be willing to continue maintaining a fork for it. In addition I have setup Github Actions to automatically run the build process and added an action to automatically deploy the docs to https://vianetz.github.io/spectre-css/. Let me know your input, I'm happy to merge more pull request proposals if they make sense. |
Yeah, I think it's about time. I created an organisation called Picturepan Too (see what I did there?) I figure this could be more neutral than a single developer having to take ownership. I'm happy to add those who want to step up, or could just delete if it's deemed too complicated. Would be good then to:
Later improvements might include:
Thoughts? Suggestions? EDIT: I created a discussion here. |
This PR has been merged into my updated fork of Spectre 0.6.0. |
There is also spectre-org/spectre-css, but it’s updated some months ago, unlike niutech’s fork which is updated a few days ago. |
spectre-org/spectre-css 1.0.0. is based on 0.5.9 and update to 0.5.10 is yet to be done, whereas my fork is based on 0.5.10 with some updates, e.g. I am working on pure CSS tabs. Ideally there should be a single community-driven up-to-date repo of Spectre, but it seems spectre-org/spectre-css development has stalled. Any updates @davestewart? |
Hey @niutech, Thanks for the mention. Yes, development has stalled; I got really busy last year and after releasing the new docs and site I didn't have much more time. However, an interesting development from literally yesterday is that @picturepan2 followed me on Twitter so I sent him a message to bring him up to speed. Without pasting the bulk of the message, I ended with this:
I can actually find the time in the next few weeks / months to put some effort in. I'd like to – at least help – get Spectre to a stage where it can live on for another few years, and it would be great if that was more of a community effort. Watch this space; I'll certainly feed back on this thread, and hopefully there'll be some input from @picturepan2 as well. And regards the If yours works correctly, I would be totally happy to re-merge a better version into the new core. Cheers, |
@davestewart It would be great if you could devote your time to developing Spectre in the coming months. I'd try to submit some PR when I finish my work in progress. As for buttons, they look OK in my fork: https://niutech.github.io/spectre/elements/buttons.html EDIT: I've implemented pure CSS tabs in my fork. |
OMG that's stung me before!!! That's for noticing that; at least I can solve that now 🙏
Do you want to create an issue to discuss on spectre-org? |
OK, the margin issues I mentioned above have now been fixed in the spectre-org docs so I now consider this PR properly merged in spectre-org/spectre-css 🎉 |
sass-migrator division **/*.scss