Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

994 Add support for upper and lower #995

Closed
wants to merge 6 commits into from

Conversation

dantownsend
Copy link
Member

Resolves #994

@dantownsend dantownsend added the enhancement New feature or request label May 24, 2024
@dantownsend dantownsend added this to In progress in Enhancements via automation May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 65.90909% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 91.91%. Comparing base (919983a) to head (8b155b5).
Report is 2 commits behind head on master.

Files Patch % Lines
piccolo/columns/column_types.py 63.63% 12 Missing ⚠️
piccolo/columns/base.py 77.77% 2 Missing ⚠️
piccolo/query/methods/select.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
- Coverage   92.78%   91.91%   -0.88%     
==========================================
  Files         108      108              
  Lines        8182     8222      +40     
==========================================
- Hits         7592     7557      -35     
- Misses        590      665      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend
Copy link
Member Author

Using this instead: #996

Enhancements automation moved this from In progress to Done May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Add support for upper and lower
2 participants