Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylance fixes #906

Draft
wants to merge 82 commits into
base: master
Choose a base branch
from
Draft

Pylance fixes #906

wants to merge 82 commits into from

Conversation

dantownsend
Copy link
Member

Builds on the changes in PR #905

Similarly to Mypy, Pylance has become much stricter / more accurate over time. There are now quite a few minor type errors being reported by Pylance.

As VSCode is such a popular code editor it would be good to clean up most (if not all) of these minor errors.

I'm not sure how easy it is to add Pyright (which powers Pylance) as a linter to our CI, but will investigate.

@dantownsend dantownsend added this to In progress in Testing via automation Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (b8026da) 92.03% compared to head (c05bb5d) 78.61%.

Files Patch % Lines
piccolo/engine/postgres.py 33.33% 6 Missing ⚠️
piccolo/table.py 0.00% 4 Missing ⚠️
piccolo/columns/defaults/base.py 0.00% 3 Missing ⚠️
piccolo/apps/playground/commands/run.py 87.50% 1 Missing ⚠️
piccolo/utils/encoding.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #906       +/-   ##
===========================================
- Coverage   92.03%   78.61%   -13.42%     
===========================================
  Files         107      107               
  Lines        8145     8165       +20     
===========================================
- Hits         7496     6419     -1077     
- Misses        649     1746     +1097     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend
Copy link
Member Author

This PR is insanely big - I'm going to break it down into smaller chunks, and merge those in (starting with any changes to test files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Testing
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants