Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic-install with openSUSE support #5000

Closed
wants to merge 1 commit into from
Closed

basic-install with openSUSE support #5000

wants to merge 1 commit into from

Conversation

coogor
Copy link

@coogor coogor commented Nov 4, 2022

added support for zypper package manager and openSUSE specific naming A general remark...the script determines forst the package manager and later the operating system. should the other way round not make more sense? the distribution drives the package manager, not other way round. (in the current the link from zypper to apt-get caused some confusion....)

This pull sets up openSUSE as base system, however it still needs the native systemd support to work (#4924)

see #4947

Signed-off-by: coogor [email protected]

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

Replace this with detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues

  • How does this PR accomplish the above?:

Replace this with a detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix

  • What documentation changes (if any) are needed to support this PR?:

Replace this with a detailed list of any necessary changes


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

added support for zypper package manager and openSUSE specific naming
A general remark...the script determines forst the package manager and later the operating system.
should the other way round not make more sense? the distribution drives the package manager, not other way round.
(in the current  the link from zypper to apt-get caused some confusion....)

Signed-off-by: coogor <[email protected]>
@dschaper
Copy link
Member

dschaper commented Nov 4, 2022

Thanks for the PR but you need to read https://docs.pi-hole.net/guides/github/contributing/#technical-requirements before proceeding any further.

@dschaper
Copy link
Member

dschaper commented Nov 4, 2022

the script determines forst the package manager and later the operating system. should the other way round not make more sense

No, the package manager is independent of the OS, you can use any manager like apt on any distro.

@dschaper dschaper added the PR: Master branch PR based on Master Branch label Nov 4, 2022
@coogor coogor closed this by deleting the head repository Nov 4, 2022
coogor added a commit to coogor/pi-hole-dev that referenced this pull request Nov 5, 2022
@coogor coogor mentioned this pull request Nov 5, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Master branch PR based on Master Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants