Add stringable access check to AccessPropertiesCheck #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
(I'll get home in a few hours and fix it.) |
zonuexe
force-pushed
the
feature/property-dynamic-access-stringable-rule
branch
6 times, most recently
from
680322d to
dd89d2d
Compare
|
This pull request has been marked as ready for review. |
zonuexe
force-pushed
the
feature/property-dynamic-access-stringable-rule
branch
from
dd89d2d to
88823c7
Compare
zonuexe
force-pushed
the
feature/property-dynamic-access-stringable-rule
branch
from
88823c7 to
12c1aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#13238
In the context of property fetching, string keys are implicitly cast.
Property names starting with a number cannot be defined, but there is no need to exclude numeric, as they are accessible via the
__get()magic method.For work reasons, this branch is based on #3910, so it will be rebased once that is merged.