Update locale_get_display_x() return types #4085
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #12942 I updated the signatures of the following functions:
locale_get_display_language()
andLocale::getDisplayLanguage()
locale_get_display_name()
andLocale::getDisplayName()
locale_get_display_region()
andLocale::getDisplayRegion()
locale_get_display_script()
andLocale::getDisplayScript()
locale_get_display_variant()
andLocale::getDisplayVariant()
The
_language()
and_name()
variants never seem to return an empty string (at least I could not find any case for which they did), so I left them atnon-empty-string
.The
_region()
function returns an empty string when you give it a language code without a region.When you pass in a very long string these methods all return
false
(C source code).I added my quick testing script as an attachment. This is my first PR here so let me know if there are any other requirement.
test.zip