Add security-checker using Composer Audit #1122
Conversation
| working_dir: ./ | ||
| ``` | ||
|
|
||
| **format** |
There was a problem hiding this comment.
Can you add this one (with default value) to the code sample as well - for completeness.
There was a problem hiding this comment.
Thanks for catching this.
| ]; | ||
| } | ||
|
|
||
| public function provideExternalTaskRuns(): iterable |
There was a problem hiding this comment.
The goal of this test is to check what impact a change in configuraton has on the executed command.
Can you add a test for every configuration option as well?
There was a problem hiding this comment.
Thanks! added tests for the options.
|
|
||
| yield 'working-dir' => [ | ||
| [ | ||
| 'working_dir' => './', |
There was a problem hiding this comment.
./ Is the default value, can you test with src/ for example?
There was a problem hiding this comment.
Actually might need help here. When manually testing to another path the option works. But when modifying the test to another path I wasn't able to get the test to pass yet.
Also a side note, I think it might be a good idea for this to be fully optional ( default to null) but would require more logic to check the path for a changed composer.lock file.
There was a problem hiding this comment.
Thanks for bringing it up.
There was a problem hiding this comment.
You can probably take a look at
grumphp/src/Task/ComposerScript.php
Line 30 in 9fb0b10
There was a problem hiding this comment.
I believe this is addressed now.
|
Looks good, thanks! |
Add security-checker using Composer Audit
https://getcomposer.org/doc/03-cli.md#audit
New Task Checklist:
run()method readable?run()method using the configuration correctly?