-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to PHP Foundation with a Donate button #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I am not sure if I am willing to merge this, as this is sort of a political issue. Can you ask the internals list for ack/nack? (We might have to do a (quick) RFC for this).
index.php
Outdated
<div class='panel'> | ||
<a href='https://thephp.foundation/' class='headline'>The PHP Foundation</a> | ||
<div class='body'> | ||
<p>The PHP Foundation is a collective of people and organizations relying on the PHP language. Its mission is to ensure the long-term prosperity of the PHP language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could shorten this description a bit?
Before:
The PHP Foundation is a collective of people and organizations
relying on the PHP language. Its mission is to ensure the long-term
prosperity of the PHP language.
After:
The PHP Foundation is a collective of people and organizations
working to ensure the long-term prosperity of the PHP language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
The PHP Foundation is a collective of people and organizations, united in the mission to ensure the long-term prosperity of the PHP language.
I hope this is merged soon. Both PHP project and PHP Foundation need to help each other. Thanks. |
As suggested by @javiereguiluz and @pronskiy
🚀 Commit 9614b52 Deployed on https://web-php-pr-821.preview.thephp.foundation |
Updated text per @pronskiy's latest comment. Voting now open on RFC, closes 2024-01-31: https://wiki.php.net/rfc/promote_php_foundation |
Not very prominent on the page and difficult to see. |
Co-authored-by: Lu Fei <[email protected]>
RFC passed unanimously: https://wiki.php.net/rfc/promote_php_foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Direct those who want to contribute to the ongoing development of PHP itself to the PHP Foundation.
As suggested by Alexander Reifinger here: https://phpc.social/@ViejoViajero/111381912606384803