Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to PHP Foundation with a Donate button #821

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Nov 9, 2023

Direct those who want to contribute to the ongoing development of PHP itself to the PHP Foundation.

As suggested by Alexander Reifinger here: https://phpc.social/@ViejoViajero/111381912606384803

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I am not sure if I am willing to merge this, as this is sort of a political issue. Can you ask the internals list for ack/nack? (We might have to do a (quick) RFC for this).

@pronskiy
Copy link
Contributor

pronskiy commented Jan 7, 2024

index.php Outdated
<div class='panel'>
<a href='https://thephp.foundation/' class='headline'>The PHP Foundation</a>
<div class='body'>
<p>The PHP Foundation is a collective of people and organizations relying on the PHP language. Its mission is to ensure the long-term prosperity of the PHP language.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could shorten this description a bit?

Before:

The PHP Foundation is a collective of people and organizations
relying on the PHP language. Its mission is to ensure the long-term
prosperity of the PHP language.

After:

The PHP Foundation is a collective of people and organizations
working to ensure the long-term prosperity of the PHP language.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

The PHP Foundation is a collective of people and organizations, united in the mission to ensure the long-term prosperity of the PHP language.

@javiereguiluz
Copy link
Contributor

I hope this is merged soon. Both PHP project and PHP Foundation need to help each other. Thanks.

Copy link
Contributor

github-actions bot commented Jan 16, 2024

🚀 Commit 9614b52 Deployed on https://web-php-pr-821.preview.thephp.foundation

@jimwins
Copy link
Member Author

jimwins commented Jan 16, 2024

Updated text per @pronskiy's latest comment.

Voting now open on RFC, closes 2024-01-31: https://wiki.php.net/rfc/promote_php_foundation

index.php Show resolved Hide resolved
@lwlwilliam
Copy link
Contributor

Not very prominent on the page and difficult to see.

styles/home.css Outdated Show resolved Hide resolved
@jimwins
Copy link
Member Author

jimwins commented Feb 1, 2024

RFC passed unanimously: https://wiki.php.net/rfc/promote_php_foundation

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@saundefined saundefined merged commit c89bec8 into php:master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants