Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll padding for anchor links #1214

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add scroll padding for anchor links #1214

merged 1 commit into from
Jan 27, 2025

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Jan 27, 2025

On pages with sticky breadcrumbs, this fixes the anchored link to scroll less to account for the stickied header.

This may not be enough if the sticky bar happens to occur more space than 64 pixels (4rem) I set it to.

Example link to try on: https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.blacklist-filename

Before:
image

After:
image

Copy link
Contributor

🚀 Regression report for commit f843f56 is at https://web-php-regression-report-pr-1214.preview.thephp.foundation

Copy link
Contributor

🚀 Preview for commit f843f56 can be found at https://web-php-pr-1214.preview.thephp.foundation

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@saundefined saundefined merged commit 5f61eca into php:master Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants