Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter link scrolling to the correct position #1171

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Nov 29, 2024

The action of clicking a parameter link in manual pages was broken, as it always scrolls to the first parameter instead of clicked one.
This PR fixes the bug.

Copy link
Contributor

🚀 Regression report for commit b7b728e is at https://web-php-regression-report-pr-1171.preview.thephp.foundation

Copy link
Contributor

🚀 Preview for commit b7b728e can be found at https://web-php-pr-1171.preview.thephp.foundation

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 98641f0 into php:master Nov 29, 2024
5 checks passed
@takaram takaram deleted the fix-parameter-scroll branch December 2, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants