Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8.4: Fix the title and RFC link of PDO driver specific subclasses #1154

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Nov 21, 2024

PHP 8.4 has accepted two RFCs with similar titles, and they seem to be mixed up.

This PR also adds Pdo\Pgsql class in the list of new PDO subclasses.

Copy link
Contributor

🚀 Regression report for commit 652adc6 is at https://web-php-regression-report-pr-1154.preview.thephp.foundation

Copy link
Contributor

🚀 Preview for commit 652adc6 can be found at https://web-php-pr-1154.preview.thephp.foundation

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 71c7b31 into php:master Nov 21, 2024
5 checks passed
@takaram takaram deleted the release-84-pdo-subclasses branch November 22, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants