Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosting jQuery locally #1119

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Hosting jQuery locally #1119

merged 1 commit into from
Nov 9, 2024

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Nov 8, 2024 •
edited
Loading

Close #1117

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🚀 Regression report for commit 4c23310 is at https://web-php-regression-report-pr-1119.preview.thephp.foundation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🚀 Preview for commit 4c23310 can be found at https://web-php-pr-1119.preview.thephp.foundation

saundefined
saundefined approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 7478275 into php:master Nov 9, 2024
5 checks passed
@dragoonis
Copy link
Contributor

Hey @saundefined and @sy-records

What's the rationale behind this ticket ?

When we originally added this via a CDN was because the browser could open multiple sockets via different domains, whereas there is a limit of sockets per domain.

What has changed? Have you benchmarked the before/after on this? If so what are the results.

Thanks.

@cmb69
Copy link
Member

cmb69 commented Nov 9, 2024

See #1117.

@dragoonis
Copy link
Contributor

Thanks @cmb69 I've read that now, and @derick's comments.

What is our CDN now? Cloudfront?

@jimwins
Copy link
Member

jimwins commented Nov 9, 2024

Most/all (working towards all) of the PHP.net web services are fronted by https://www.myrasecurity.com/, which was co-founded by a long-time PHP community member.

@sy-records sy-records deleted the local/jquery branch November 9, 2024 22:16
@dragoonis
Copy link
Contributor

Thanks for replying @jimwins, I read your comment when you originally wrote it, but didn't reply. Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saundefined saundefined saundefined approved these changes

Assignees
No one assigned
Labels
Status: Preview Allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JQuery should not be loaded from external site
5 participants
@sy-records @dragoonis @cmb69 @jimwins @saundefined