-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gzip assets and wasm #67
base: master
Are you sure you want to change the base?
Conversation
This will work but this would be much more efficient to precompress the binary using Brotli and Zopfli (an efficient Gzip-compatible compressor) and configure Apache like this to serve the compressed file directly: https://blog.desgrange.net/post/2017/04/10/pre-compression-with-gzip-and-brotli-in-apache.html |
We run nginx with a CDN in front. I would like to to see this tried out first on something that the standard code path doesn't hit.
|
I reviewed too fast. For NGINX it's easier because it supports gzip/zopfli pre-compression natively and Brotli with a module. Just use the |
On php/web-php#1097 you write "IMO we should get rid of cached.php and leave assets compression and cache management to nginx (or caddy).". I don't want to do that just now, and would prefer if everything was web server agnostic. We're thinking of moving everything to either apache or nginx (rather Apache, I think). A PR with a new script to build a new WASM file can just be a new file in this repository. |
I discussed this with @dunglas basically I'll add a gzip static compression and enable |
@dunglas could you check? I think that the defaults are fine but you've studied this a bit more then I did. Brotli isn't available out of the box maybe we can add it later (not sure how).