Fix GH-13264: fgets() and stream_get_line() do not return false on filter fatal error #18778
+66
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter fatal error This happens because there are no checks in php_stream_fill_read_buffer calls. This should not fail always but only on fatal error so special flag is needed for that. Closes phpGH-18778
bukka
force-pushed
the
stream_gh13264_filter_fatal_err
branch
from
ae4ee72 to
b85429e
Compare
bukka
changed the title
n-peugnet
reviewed
Jun 5, 2025
| while (($line = stream_get_line($stream, 0, "\n")) !== false) { | ||
| $error = error_get_last(); | ||
| if ($error !== null) { | ||
| // An error is thrown but fgets didn't return false |
There was a problem hiding this comment.
There is a minor copy-paste error in this comment:
Suggested change
| // An error is thrown but fgets didn't return false | |
| // An error is thrown but stream_get_line didn't return false |
There was a problem hiding this comment.
Thanks, will change it before the commit (sparing CI cycles for now :) )
nielsdos
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because there are no checks in php_stream_fill_read_buffer calls. This should not fail always but only on fatal error so special flag is needed for that.