Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml_parse_file_002.phpt on PHP 8.4 #86

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix yaml_parse_file_002.phpt on PHP 8.4 #86

merged 1 commit into from
Sep 30, 2024

Conversation

andypost
Copy link
Contributor

Closes #85

@andypost
Copy link
Contributor Author

Somehow I can't reproduce it using CI #87

@cmb69 cmb69 mentioned this pull request Sep 30, 2024
Merged
@cmb69
Copy link
Member

cmb69 commented Sep 30, 2024

Somehow I can't reproduce it using CI #87

Most likely because setup-php hadn't been updated with the respective change. The issue can be seen with PHP 8.4 on Windows, though; see PR #89.

@cmb69 cmb69 merged commit 3001d95 into php:php7 Sep 30, 2024
13 checks passed
@cmb69
Copy link
Member

cmb69 commented Sep 30, 2024

Thank you!

@andypost andypost deleted the 85-php84 branch October 8, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4.0 beta4 test yaml_parse_file_002.phpt fails
2 participants
@andypost @cmb69