Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust lib option, update zstd, and extern rusqlite #38

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kodeschreiber
Copy link

Good Evening,

This PR edits the following:

  1. Adds the "lib" flag to the "[lib]" section to make crate usable as a Cargo library
  2. Updated the version of the "zstd" to fix a bug in version "0.11.2" (see below for details)
  3. Wrapped a parameter with "Some()" to make compatible with updated zstd API
  4. Added an "pub extern crate rusqlite" to help resolve compilation issues

Most of these changes are based on existing issues and issues that I also encountered with the current 3.2.0 release. The zstd error I was running into was:

error[E0432]: unresolved import `zstd_sys::ZSTD_cParameter::ZSTD_c_experimentalParam6`
   --> <USER>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zstd-safe-5.0.2+zstd.1.5.2/src/lib.rs:467:13
    |
467 |             ZSTD_c_experimentalParam6 as ZSTD_c_targetCBlockSize,
    |             -------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |             |
    |             no `ZSTD_c_experimentalParam6` in `ZSTD_cParameter`
    |             help: a similar name exists in the module: `ZSTD_c_experimentalParam1`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `zstd-safe` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Feel free to suggest any edits to this patch. Thanks!

@kodeschreiber kodeschreiber marked this pull request as draft May 17, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant