fix: interim releif for dark theme white flash on startup #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address shell component of: phcode-dev/phoenix#2149
visibility: falselogic as suggested in the root Tauri issue: Allow changing the webview background color tauri-apps/tauri#1564 as it lead to add load time delay perception of up to 200ms(Though the actual load time is not affected, just that we hide the main window until black paint is done.) . This will affect the light weight perception of the app and hence cannot be the default.So as a middle ground, adding optional support so that users can selectively trade-off delayed startup till the dark theme is rendered or faster show of app window.
The impl reads an existing
boot_config.jsonfile in app config dir and also adds fault tolarance to determine if to hide all on start. Its set to false by default and can be set to true from phcode settings.