Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for handling SML and directory related configuration keys #267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anakinj
Copy link

@anakinj anakinj commented Jan 4, 2024

While configuring a new instance of the latest (7.1.0) SQL version I noticed that some properties from the configuration files were not taken into account and always needed to be changed via the settings UI.

Looking closer into the issue I noticed a few problems:

  • When reading the SML/Directory related configuration values from the DB the fallback will be the hardcoded values, not the ones from the config file
  • The application.properties resource shipped within the app had the new keys define that prevented the old keys from being read

This PR fixes these by:

  • Fallback to set config values instead of constants when reading settings from DB
  • Use the new config keys when reading the SML/Directory related values
  • Disable the SML/Directory related values from the default application.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant