-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering feature for logs #309
base: main
Are you sure you want to change the base?
Conversation
This looks awesome! Only thing missing in the date picker. You can use a standard html calendar input for now, no need for anything fancy. Also we might need to allow filtering by a specific time range too. There could be a large number of logs generated in a 24hr period, and it would be useful to be able to narrow it down. |
Should I do filtering action on the data from the front end itself or does it need to write new APIs for the filtering? |
We definitely need to apply filtering logic on the backend, since log data is likely to be very large. Let's extend the existing query resolver for logs with arguments required for these filters. Lmk if you want some help deciding on the spec for these arguments. Remember to keep things modular and allow the frontend to query things in a flexible way. |
All the APIs are defined in |
Yep, the logs resolver is here: console/backend/backend/schema.py Line 509 in cb7d381
|
🔍 Overview
This initial PR for the issue #129 has the UI update for the filtering feature of logs
💡 Proposed Changes
Detail the proposed changes, including new features, bug fixes, or improvements. Explain how these changes impact the project, including any internal structure alterations or refactorings.
🖼️ Screenshots or Demo
Screen.Recording.2024-07-28.at.11.24.31.mov
📝 Release Notes
Summarize the changes in a user-friendly manner. Highlight new features, bug fixes, and any breaking changes, including migration steps or deprecated functionalities.
❓ Open Questions
If there are aspects of the changes that you're unsure about or would like feedback on, list them here.
🧪 Testing
Describe the testing strategy. List new tests added, existing tests modified, and any testing gaps.
🎯 Reviewer Focus
This PR only contains the UI part of the filter for logs. Please verify the UI.
Things left in this
A Dropdown view for the user selection similar to this
![Screenshot 2024-07-28 at 11 33 14](https://private-user-images.githubusercontent.com/50370450/352792642-b53d776c-1788-4cd6-8cca-f42af479d157.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTgzNTQsIm5iZiI6MTczOTQ1ODA1NCwicGF0aCI6Ii81MDM3MDQ1MC8zNTI3OTI2NDItYjUzZDc3NmMtMTc4OC00Y2Q2LThjY2EtZjQyYWY0NzlkMTU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE0NDczNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkMTAzNTc1ZDc2MjRhMDg4M2UyYjc5YTk4MWIzNTU3MWVkMDAyOTliYjM2OWQyYWZhOWZiY2JjMGYwY2IwMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.0SSKkvYnOgEk-P7mohGql9YSvkjTwlZTQ-0PrPqQeb0)
To add Datepicker
➕ Additional Context
Provide any additional information that might be helpful for reviewers and future contributors, such as links to related issues, discussions, or resources.
✨ How to Test the Changes Locally
Give clear instructions on how to test the changes locally, including setting up the environment, any necessary commands, or external dependencies.
💚 Did You...