Fix issue 17908 - Rename argument #17913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fixing add argument #17908 |
Member
|
Thank you for the fix. |
balsa-sarenac
approved these changes
Mar 4, 2025
| self configureMessage. | ||
|
|
||
| refactoring isMethodDefinitionUnchanged ifTrue: [ ^ self ]. | ||
| shouldEscape ifTrue: [ ^ self ]. "What is the use of this variable: shouldEscape?" |
Member
There was a problem hiding this comment.
User can invoke this refactoring by mistake or give up while typing new name (in requestNewMessage). If this happens, user clicks on Cancel and with this variable we propagate that cancel to escape this loop. Maybe there is a better way to do this?
Member
|
Tx Balsa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @ValentinBourcier