Only pass background exceptions when we #shouldPassBackgroundFailures (fixes #17813) #17814
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixes pharo-project#17813) Normally during test cleanup we will terminate any suspended background processes, so they will not actually get to resume and hit the #pass. However if the error was raised in an #ensure: block, the background process will finish executing the handler even when sent #terminate, so we need to avoid passing the exception and opening a debugger.
|
The CI failure looks like it's just in "Archive JUnit-formatted test results" and no tests actually failed? |
|
This seems OK to me but this part of the system is pretty obscure to me. If someone else can review I'd appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally during test cleanup we will terminate any suspended background processes, so they will not actually get to resume and hit the #pass. However if the error was raised in an #ensure: block, the background process will finish executing the handler even when sent #terminate, so we need to avoid passing the exception and opening a debugger.
I think this is correct—certainly the behavior of
passBackgroundFailures, e.g. when a halt is encountered, should be unaffected as that explicitly causesshouldPassBackgroundFailuresto returntruebefore resuming anything. But I'd appreciate another set of eyes on it, and if I should be checking a different condition, or a new condition variable needs to be added, that's possible too.