Skip to content

fix/issue-939 - Using AIO Event for sending #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: pharo-10
Choose a base branch
from
Open

fix/issue-939 - Using AIO Event for sending #1015

wants to merge 1 commit into from

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Aug 25, 2025 •
edited
Loading

  • Adding a flag to handle if the socket is blocked in a send.
  • Handling the async event for this case.

Fix #939

@tesonep
- Adding a flag to handle if the socket is blocked in a send.
b9c46d9 
- Handling the async event for this case.
mumez
mumez reviewed Aug 27, 2025
View reviewed changes
extracted/plugins/SocketPlugin/src/common/SocketPluginImpl.c
@@ -261,7 +262,7 @@ typedef struct privateSocketStruct
#define SOCKETERROR(S) (PSP(S)->sockError)
#define SOCKETPEER(S) (PSP(S)->peer)
#define SOCKETPEERSIZE(S) (PSP(S)->peerSize)

#define SOCKET_WATINGTOSEND(S) (PSP(S)->waitingToSend)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] SOCKET_WATINGTOSEND -> SOCKET_WAITINGTOSEND

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mumez mumez mumez left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket>>sendData: hot-spins if the other side is unresponsive
2 participants
@tesonep @mumez