removed BlLayout, BlFlowLayout and BlLinearLayout #= and #hash #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've passed two days digging and digging everywhere because of an issue related to this bad kind of redefinition of #=. It does'nt make sense to have such #= implementation for so complex objects and that may have specific subclasses. moreover, when one send #layout: with a new layout as argument, it should ensure that the new layout instance is taken, otherwise, one would have to test the equality then change the current layout state which could lead to questionable code and many alternatives to check.
|
fix #699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've passed two days digging and digging everywhere because of an issue related to this bad kind of redefinition of #=. It does'nt make sense to have such #= implementation for so complex objects and that may have specific subclasses. moreover, when one send #layout: with a new layout as argument, it should ensure that the new layout instance is taken, otherwise, one would have to test the equality then change the current layout state which could lead to questionable code and many alternatives to check.