-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #39: CoEQ test data #45
Conversation
Hi @pharmaverse/admiralmetabolic - this is a PR to add a very simple CoEQ test dataset. I have added a couple of reviewers, but could anyone with capacity please take a look and see if the SDTM structure makes sense to you? I have not worked myself with the data and the only thing I had access to was some raw, unmapped data from the Roche side, so I had to "guess" the SDTM mapping! In particular, I also guessed the QSCAT/QSSCAT/QSTEST assignments, but of course we can modify them if needed. @kathrinflunkert note that I have added the licensing disclaimer as well, which we'll need to send to UoLeeds before we merge in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I don't have much as I don't know the specific of actually using CoEQ.
I have a couple of things I would prefer being changed over to tidyverse, but besides that it looks good! :)
#39: implemented suggestions from code review Co-authored-by: Anders Askeland <[email protected]>
…abolic into 39_coeq_test_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose this small change in library calls.
Co-authored-by: Anders Askeland <[email protected]>
Co-authored-by: Andrii Yurovskyi <[email protected]>
Thanks @kathrinflunkert @yurovska for your reviews. I removed QSSCAT, ensured the answer to question 20 is categorical, and made the other suggested updates. Please review again - looking to merge by EoB Wed this week. Thanks! Note that checks are failing due to some issue in admiralci, not anything here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manciniedoardo Thanks for the updates. Just one pedantic comment, otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @manciniedoardo !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the updates!
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral<ext> (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()