Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #39: CoEQ test data #45

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Closes #39: CoEQ test data #45

merged 11 commits into from
Nov 5, 2024

Conversation

manciniedoardo
Copy link
Collaborator

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Oct 24, 2024

Code Coverage

Package Line Rate Health
admiralmetabolic 100%
Summary 100% (3 / 3)

@manciniedoardo
Copy link
Collaborator Author

Hi @pharmaverse/admiralmetabolic - this is a PR to add a very simple CoEQ test dataset. I have added a couple of reviewers, but could anyone with capacity please take a look and see if the SDTM structure makes sense to you? I have not worked myself with the data and the only thing I had access to was some raw, unmapped data from the Roche side, so I had to "guess" the SDTM mapping! In particular, I also guessed the QSCAT/QSSCAT/QSTEST assignments, but of course we can modify them if needed.

@kathrinflunkert note that I have added the licensing disclaimer as well, which we'll need to send to UoLeeds before we merge in.

Copy link
Member

@AndersAskeland AndersAskeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't have much as I don't know the specific of actually using CoEQ.

I have a couple of things I would prefer being changed over to tidyverse, but besides that it looks good! :)

R/data.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
Copy link
Member

@AndersAskeland AndersAskeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose this small change in library calls.

data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
data-raw/qs_metabolic.R Outdated Show resolved Hide resolved
@manciniedoardo
Copy link
Collaborator Author

manciniedoardo commented Nov 4, 2024

Thanks @kathrinflunkert @yurovska for your reviews. I removed QSSCAT, ensured the answer to question 20 is categorical, and made the other suggested updates. Please review again - looking to merge by EoB Wed this week. Thanks!

Note that checks are failing due to some issue in admiralci, not anything here.

Copy link
Contributor

@yurovska yurovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manciniedoardo Thanks for the updates. Just one pedantic comment, otherwise looks good to me.

data-raw/qs_metabolic.R Show resolved Hide resolved
Copy link
Member

@AndersAskeland AndersAskeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @manciniedoardo !

Copy link
Contributor

@kathrinflunkert kathrinflunkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the updates!

@manciniedoardo manciniedoardo merged commit 26cac24 into main Nov 5, 2024
9 of 15 checks passed
@manciniedoardo manciniedoardo deleted the 39_coeq_test_data branch November 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants