Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2480 derive pair of variables #2503
Closes #2480 derive pair of variables #2503
Changes from 83 commits
97b58c7
b79a558
5d2b1bc
95c1cc2
f1f1984
dd38c99
8b58650
7c8d4fb
b2a1a26
269d3b2
0433537
ba088b1
ad514a0
7d4a3e3
74f1e81
234199e
ce4b739
3d4bdb9
379c831
881f6f1
c19e4ee
265ecea
b5041be
dcfe16a
693e1a3
c186776
b461453
0f1fef6
d1db0a1
1dedbb7
3f6233d
4267dfc
fa21e81
0dbbe67
4fc3180
d09a9c7
daa6ead
c2c2207
acbf169
33ffc12
cc210f1
bb74943
f4ec115
8e727d2
a3d5751
7a912c9
69d7ea4
2533193
98043bf
ede7f99
16b2c38
126a17d
930f7f5
9b537db
e6213a7
a6011db
030e478
bef70a4
2f06d60
e933605
8b0775b
381ec72
dfc5289
089e90a
eac433f
e98c228
ab4390b
7c089eb
023a535
7e27b3a
867b66f
8660179
8caf227
e7882f0
96bdd8d
15c1007
5a6c6ec
0b803ee
b3a925a
05f973e
09097ac
e846b67
5ab8252
e0a7995
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR - but just thinking should we alert the user that something is amiss with their logic if they don't abide by our warning? Not sure if we can detect this first?? @bundfussr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bms63 , do you mean issuing a warning if there are records which doesn't match any of the by groups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the overlap discussion that is in the documentation - like something should be finer in logic??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this would be helpful. There are use cases where it makes sense to use overlapping categories, e.g.,
Issuing a warning in this case would force the users to suppress the warning or replace
TRUE
withis.na(AVAL) | is.na(ANRHI)
.