Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1839 dummy function created #2483

Closed
wants to merge 8 commits into from
Closed

Closes #1839 dummy function created #2483

wants to merge 8 commits into from

Conversation

steventing12
Copy link
Contributor

@steventing12 steventing12 commented Jul 25, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@steventing12 steventing12 linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 25, 2024

Code Coverage

Package Line Rate Health
admiral 96%
Summary 96% (4955 / 5154)

@manciniedoardo
Copy link
Collaborator

@steventing12 thanks for the PR - please give each item in the tasklist a go and shout with any questions/issues.

@manciniedoardo
Copy link
Collaborator

Hi @steventing12 any issues fixing the last checks?

@steventing12
Copy link
Contributor Author

Hi @steventing12 any issues fixing the last checks?

Hi @manciniedoardo, the checks failed at the spellcheck stage:

Run insightsengineering/r-spellcheck-action@v3
Run options(repos = c(CRAN = "https://cloud.r-project.org/"))
Loading required package: spelling
Run cd .
WORD FOUND IN
Rothstein README.md:192

Number of misspelled words: 1
You may correct the spellings of the words above or add them to the "inst/WORDLIST" file by running spelling::update_wordlist()
Error: Process completed with exit code 1.

I had run spelling::update_wordlist() but it says no updated required. Any suggestions?

@manciniedoardo
Copy link
Collaborator

Rothstein

Try manually adding "Rothstein" to inst/wordlist

@manciniedoardo
Copy link
Collaborator

Looks good, thanks @steventing12 !

@bms63 bms63 deleted the 1839_dummy_st branch September 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DUMMY ISSUE FOR ONBOARDING
2 participants