Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1839 onboarding dummy function created #1993

Closed
wants to merge 4 commits into from

Conversation

nicholaswe
Copy link

@nicholaswe nicholaswe commented Jul 4, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@nicholaswe nicholaswe linked an issue Jul 4, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Code Coverage

Package Line Rate Health
admiral 99%
Summary 99% (4202 / 4258)

@nicholaswe nicholaswe requested a review from bms63 July 5, 2023 19:14
@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

Just use this and push up and we should be good to go!

image

@nicholaswe
Copy link
Author

Wordlist updated!

Should I close the pull request now, @bms63?

@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

Yes please close- after the Check Templates action is completed. This only happens after someone approves a PR.

@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

Templates passed - nicely done!!

I recommend looking this issue for potential next work if you are interested - #1875

@bms63 bms63 closed this Jul 5, 2023
@nicholaswe
Copy link
Author

Thanks for the guidance and help, @bms63.
I'll take a look at #1875.

@bms63 bms63 deleted the 1839_dummy_onboaring@devel branch September 12, 2023 18:02
@bms63 bms63 removed a link to an issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants