Skip to content

Update to libpg_query 17-6.1.0 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Conversation

lfittl
Copy link
Member

@lfittl lfittl commented Apr 2, 2025

This fixes strchrnul compatibility on macOS 15.4+

Note that the libpg_query release is technically not tagged yet (but this branch could be used in the interim), I plan to make a libpg_query release within the next day, and then release a new pg_query version as well.

Fixes #327

@simba909
Copy link

simba909 commented Apr 2, 2025

@lfittl Any chance we could get this back-ported to pg_query 5 or 4? We're using 4.2.3 in one of the projects I'm working on due to PostgreSQL 14 (maybe pg_query 6.1.0 will also work with PostgreSQL 14 in which case that's fine)

@lfittl lfittl force-pushed the update-to-libpgquery-17-6.1.0 branch from 941bbd8 to 61646f0 Compare April 2, 2025 23:36
@lfittl lfittl merged commit e6a0f1b into main Apr 2, 2025
10 checks passed
@lfittl
Copy link
Member Author

lfittl commented Apr 3, 2025

@lfittl Any chance we could get this back-ported to pg_query 5 or 4? We're using 4.2.3 in one of the projects I'm working on due to PostgreSQL 14 (maybe pg_query 6.1.0 will also work with PostgreSQL 14 in which case that's fine)

It would be a decent amount of extra effort, since those are older parser versions too (where we'd have to update to the corresponding Postgres sources, etc).

Is there a reason you can't upgrade? The parser is generally compatible with older releases (so it shouldn't be an issue to be on pg_query 6.1.0 even when running against Postgres 14 type queries), the only concern could potentially be if you rely on any APIs that changed between the releases.

@lfittl lfittl deleted the update-to-libpgquery-17-6.1.0 branch April 3, 2025 01:16
@simba909
Copy link

simba909 commented Apr 3, 2025

[...] The parser is generally compatible with older releases (so it shouldn't be an issue to be on pg_query 6.1.0 even when running against Postgres 14 type queries) [...]

Ah! That's nice, then I think we're good. Thank you! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation failing on MacOS 15.3, ARM platform, pg_query 6.0.0
3 participants