Upgrade Go to v1.24 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryotarai
force-pushed
the
ryotarai/upgrade-k8s-libraries-v0.32
branch
from
e6d6aad to
e9d0d75
Compare
…e's client options
ryotarai
force-pushed
the
ryotarai/upgrade-k8s-libraries-v0.32
branch
2 times, most recently
from
a03ddc9 to
f92d1f4
Compare
|
📝 This PR also supports Kubernetes 1.32. |
utam0k
reviewed
Jun 3, 2025
Comment on lines
+63
to
+64
| // NOTE(ryotarai): The injecting mechanism is removed in https://github.com/kubernetes-sigs/controller-runtime/pull/2134 | ||
| // For now, the decoder and client are injected manually, but we might want to replace this with sigs.k8s.io/controller-runtime/pkg/builder.WebhookManagedBy |
There was a problem hiding this comment.
👀 May I ask you to create the issue for addressing this comment?
There was a problem hiding this comment.
Created an issue for this: #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.