Fix selector for 'id' to support semi-colons #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h currently fails.
gmcelhanon
force-pushed
the
fix-jquery-selector-for-ids-with-special-characters-fails
branch
from
8ffa097
to
0e54924
Compare
gmcelhanon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
preparedIdfunction produces a jQuery selector that fails on ids containing a;.The failure I encountered was on an internal SSO page that was generating ids for controls using values like
34:2;a. ChromeIPass was generating errors in the console, and even though theprepareIdfunction was escaping some characters, the semi-colon was not included in the set. Adding the semi-colon to the set of characters being escaped corrected the issue.