-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ubuntu 21.10 build #391
Open
ChrisMacGregor
wants to merge
6
commits into
pfalcon:master
Choose a base branch
from
ChrisMacGregor:fix-ubuntu-21.10-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix ubuntu 21.10 build #391
ChrisMacGregor
wants to merge
6
commits into
pfalcon:master
from
ChrisMacGregor:fix-ubuntu-21.10-build
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versions later than 3 (e.g., bash 4 and bash 5). This is from: https://github.com/larsks/docker-image-esp-open-sdk/blob/master/0001-Fix-build-errors-with-bash-4.patch
isl.gforge.inria.fr seems to no longer work. This is from: pfalcon#386
…no longer available from the one that had been used. NOTE: The reason the old location didn't work is that expat-2.1.0.tar.gz on sourceforge had been renamed to "expat-2.1.0-RENAMED-VULNERABLE-PLEASE-USE-2.3.0-INSTEAD.tar.gz"... I considered seeing if it would work using 2.3.0 as suggested, but 2.3.0 similarly redirects to 2.4.1, and the immediate goal is to get this stuff to build with minimally intrusive changes. However, it would probably be wise to switch to a newer expat!
…gcc (e.g. gcc 11.2 on Ubuntu 21.10). The error was: .../esp-open-sdk/crosstool-NG/.build/src/gcc-4.8.5/gcc/reload1.c:89:24: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
…y fixing gdb to not use an internal-only API. As suggested by canardos in their 2018-08-28 comment on pfalcon#339 applying (by hand) this patch: https://sourceware.org/legacy-ml/gdb-patches/2018-05/msg00863.html to gdb/python.c fixed the issue. This patch is the diff that resulted.
This was referenced Jan 12, 2022
Closed
Thank you ChrisMacGregor. Compiled perfectly in WSL (debaian) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal set of changes to get the build to work on Ubuntu 21.10, which (based on the numerous posts, issues, questions, etc. that I found in the course of figuring out how to get this to build) would apparently save a lot of people a lot of trouble. The MicroPython ESP8266 port points to your repo, so anyone trying to follow those instructions is going to run into these same problems.