Add Windows support in key critical areas. #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Pex still does not support Windows, this is work towards pex-tool#2658. In particular, support is added for: + Shared and exclusive file locks. + Versions os os.link, os.symlink and os.rename that either work with Windows or work with most modern Windows setups. + Executable file detection that works for Windows. + Partial support for Windows venvs by accomodating its Scripts dir and console script style (.exe stubs). Informal testing shows the following work: + `py -mpex cowsay` + `py -mpex cowsay -ccowsay {,--venv} -- -t Moo!` + `py -mpex cowsay -ccowsay {,--venv} -ocowsay.pex` + `py -mpex cowsay -ccowsay -ocowsay.pex --scie {eager,lazy}` + `py -mpex.cli cache {prune,purge}` Important non-working things include: + The developer system: `tox ...` needs work most fundamentally. + Venv scripts / venv scies: Need support for Windows .exe stub scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Pex still does not support Windows, this is work towards #2658.
In particular, support is added for:
os.link,os.symlinkandos.renamethat either workwith Windows or work with most modern Windows setups.
Scriptsdirand console script style (
.exestubs).Informal testing shows the following work:
py -mpex cowsaypy -mpex cowsay -ccowsay {,--venv} -- -t Moo!py -mpex cowsay -ccowsay {,--venv} -ocowsay.pexpy -mpex cowsay -ccowsay -ocowsay.pex --scie {eager,lazy}py -mpex.cli cache {prune,purge}Important non-working things include:
tox ...needs work most fundamentally..exestubscripts.