Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hv_fetchs() instead of hv_fetch() with literal key and manual length #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use hv_fetchs() instead of hv_fetch() with literal key and manual length #133

wants to merge 1 commit into from

Conversation

ilmari
Copy link
Contributor

@ilmari ilmari commented Sep 2, 2024

This avoids potential length miscounting bugs. hv_fetchs() was introduced in Perl 5.10, but is covered by dbipport.h.

@ilmari
Use hv_fetchs() instead of hv_fetch() with literal key and manual length
67091ca 
This avoids potential length miscounting bugs. hv_fetchs() was
introduced in Perl 5.10, but is covered by dbipport.h.
@ilmari
Copy link
Contributor Author

ilmari commented Sep 3, 2024

I just noticed that the github actions only test the latest minor of each major, and hv_fetchs was backported to 5.8.9. I've tested manually that this (and an equivalent change in DBD::Pg) also works on 5.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilmari