Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a defined owner #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a defined owner #10

wants to merge 1 commit into from

Conversation

yanick
Copy link
Contributor

@yanick yanick commented Oct 1, 2016

Commit af13adb is breaking the tests. I've switched

    $owner->

for

    $self->{OWNER}->

and now things are passing.

BIG WARNING: I'm not sure of the fix
af13adb was trying to do in the first place, so my
own patch could be flawed.

@yanick
Use a defined owner
2fdb87b 
Commit af13adb is breaking the tests. I've switched

        $owner->

for

        $self->{OWNER}->

and now things are passing. Big warning: I'm not sure of the fix
af13adb was trying to do in the first place, so my
own patch could be flawed.
@rehsack
Copy link
Member

rehsack commented Mar 30, 2017

I'm sorry - for whatever reason my watches wasn't up-to-date and I didn't receive any notification. I fixed that already during reviewing other PR's. I mention you in Changes, is it ok?

@yanick
Copy link
Contributor Author

yanick commented Mar 30, 2017

Absolutely. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanick @rehsack